Skip to content

fix(mock-contracts): implement MockTaskManager.isPubliclyAllowed - #331

Open
0xlrvexia wants to merge 1 commit into
FhenixProtocol:masterfrom
0xlrvexia:fix/mock-tm-is-publicly-allowed
Open

fix(mock-contracts): implement MockTaskManager.isPubliclyAllowed#331
0xlrvexia wants to merge 1 commit into
FhenixProtocol:masterfrom
0xlrvexia:fix/mock-tm-is-publicly-allowed

Conversation

@0xlrvexia

Copy link
Copy Markdown

Problem

MockTaskManager.isPubliclyAllowed always reverts with NotImplemented().

Production TaskManager implements:

function isPubliclyAllowed(uint256 ctHash) external view returns (bool) {
return acl.globalAllowed(ctHash);
}

On the mock side, allowGlobal already works and MockACL.globalAllowed is implemented. Only the matching read path was left stubbed, so FHE.isPubliclyAllowed / public-ACL checks cannot be used in local mock tests.

Fix

Delegate to acl.globalAllowed(ctHash), matching production.

Scope

  • 1 file, ~2 lines
  • No ABI or storage layout change

Test plan

  • After allowGlobal, isPubliclyAllowed returns true
  • Without global allow, returns false
  • Existing mock-related tests still pass

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 387f098

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

@0xlrvexia is attempting to deploy a commit to the Fhenix Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant