fix(abi): encrypted array reads print a debug line to the console - #336
Open
hharry11 wants to merge 1 commit into
Open
fix(abi): encrypted array reads print a debug line to the console#336hharry11 wants to merge 1 commit into
hharry11 wants to merge 1 commit into
Conversation
A leftover console.log in transformEncryptedReturnTypes fires whenever a contract read returns an array of encrypted values, printing the internal type, the array size and the raw handles. It is the only console call in packages/abi and there is no no-console rule to catch it. Added a test that spies on console.log for the same path.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
🦋 Changeset detectedLatest commit: fc5b268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@hharry11 is attempting to deploy a commit to the Fhenix Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package's own test output shows it:
A leftover console.log in transformEncryptedReturnTypes fires whenever a contract read returns an array of encrypted values, printing the internal type, the array size and the raw handles into the consumer's console. It is the only console call anywhere in packages/abi, so it reads as accidental rather than intended, and there is no no-console rule to catch it.
Removed the line and added a test that spies on console.log over the same path. With the line still in place that test fails with "expected log to not be called at all, but actually been called 1 times".
Full abi suite is 70 passing, check:types and eslint are clean, build succeeds, and a patch changeset is included.