update secret key in kodiak secret

[LeoQuote]

turns out there's a bit missing change 🤦‍

[etiennetremel]

@LeoQuote could you also rename the key in the values.yaml file?

Use:

githubV4ApiUrl:

Instead of:

githubV4ApiRoot:

[LeoQuote]

I've been thinking about it , why this is so hard to achive such simple thing. I think there could be a better way,

like we can just provide an "env" value , and render it as is in deployment.

you can write :

env:
    - name: PRIVATE_KEY
      valueFrom:
        secretKeyRef:
          name: kodiak
          key: PRIVATE_KEY

could this be a better solution?

[LeoQuote]

yes change in values.yaml was coverd by another pr: #18

[etiennetremel]

I've been thinking about it , why this is so hard to achive such simple thing. I think there could be a better way,

like we can just provide an "env" value , and render it as is in deployment.

you can write :

env:
    - name: PRIVATE_KEY
      valueFrom:
        secretKeyRef:
          name: kodiak
          key: PRIVATE_KEY

could this be a better solution?

Yes indeed, we can keep the current config but still add a additionalEnv: field in the values.yaml which would append custom block under env:.