Skip to content

Add reopenOnFocusWhenValid prop #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygout merged 2 commits into from
Jan 12, 2026
Merged

Add reopenOnFocusWhenValid prop #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
285d2d4
Add reopenOnFocusWhenValid prop
andygout Jan 10, 2026
d6dc56a
Merge branch 'master' into add-reopen-on-focus-when-valid-prop
frshwtr Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/accessible-autocomplete.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.preact.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lib/accessible-autocomplete.react.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions src/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default class Autocomplete extends Component {
confirmOnBlur: true,
showNoOptionsFound: true,
showAllValues: false,
reopenOnFocusWhenValid: false,
required: false,
tNoResults: () => 'No results found',
tAssistiveHint: () => 'When autocomplete results are available use up and down arrows to review and enter to select. Touch device users, explore by touch or with swipe gestures.',
Expand Down Expand Up @@ -259,8 +260,11 @@ export default class Autocomplete extends Component {

handleInputFocus (event) {
const { query, validChoiceMade, options } = this.state
const { minLength } = this.props
const shouldReopenMenu = !validChoiceMade && query.length >= minLength && options.length > 0
const { minLength, reopenOnFocusWhenValid } = this.props
const shouldReopenMenu =
(!validChoiceMade || reopenOnFocusWhenValid) &&
query.length >= minLength &&
options.length > 0

if (shouldReopenMenu) {
this.setState(({ menuOpen }) => ({ focused: -1, menuOpen: shouldReopenMenu || menuOpen, selected: -1 }))
Expand Down