This repository was archived by the owner on Feb 10, 2021. It is now read-only.
doc(configuration): Add missing documentation for stage#3
Open
ShaunEdiger wants to merge 1 commit intoFinancial-Times:masterfrom
Open
doc(configuration): Add missing documentation for stage#3ShaunEdiger wants to merge 1 commit intoFinancial-Times:masterfrom
ShaunEdiger wants to merge 1 commit intoFinancial-Times:masterfrom
Conversation
…ck` property for each function; otherwise, the function is skipped, even if an event is configured for a healthcheck - fix some typos
mgarciadelojo
approved these changes
Dec 18, 2019
mgarciadelojo
left a comment
mgarciadelojo
left a comment
There was a problem hiding this comment.
This would be really useful to have, since the documentation is not clear enough...
Contributor
|
@ShaunEdiger We no longer use this package at FT. If you want the npm project transferred to you let me know: rhys.evans@ft.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
sls deployExpected Result
The plugin will detect the healthchecks specified within the lambda function events.
Actual Result
The plugin does not detect the healthchecks specified within the lambda function events. Healthcheck processing is skipped entirely (
HealthCheck: no lambda to check).What's going on
There is code within the plugin that toggles whether a lambda function will be included for healthcheck processing. It appears to be undocumented.
What this pull request does
The acceptable configuration values have been added to the README. There are also a few typo corrections.