fix: hard delete spools via Spoolman API#2
Open
fazerize wants to merge 1 commit intoFire-Devils:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Spoolman-compatible API implementation so that deleting a spool via DELETE /spool/{id} performs a true database delete (rather than archiving), while keeping the existing endpoint shape and success response. It also documents the new semantics and bumps the plugin version.
Changes:
- Change spool deletion behavior to hard-delete the spool record and emit a
deletedevent. - Document that
DELETE /spool/{id}is a permanent delete. - Bump plugin version from 1.1.8 to 1.1.9.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spoolmanapi/service.py | Switches delete_spool from “archive” to db.delete() + commit while keeping the same API contract. |
| spoolmanapi/plugin.json | Version bump to 1.1.9 to reflect behavior change. |
| README.md | Updates endpoint description and adds a “Delete semantics” section clarifying permanent deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /spool/{id}to permanently delete the FilaMan spool instead of only archiving itVerification
python3 -m compileall spoolmanapigit diff --check