Skip to content

fix: hard delete spools via Spoolman API#2

Open
fazerize wants to merge 1 commit intoFire-Devils:mainfrom
fazerize:fix/hard-delete-spools
Open

fix: hard delete spools via Spoolman API#2
fazerize wants to merge 1 commit intoFire-Devils:mainfrom
fazerize:fix/hard-delete-spools

Conversation

@fazerize
Copy link
Copy Markdown

Summary

  • Change Spoolman-compatible DELETE /spool/{id} to permanently delete the FilaMan spool instead of only archiving it
  • Keep the existing Spoolman-compatible endpoint and success response
  • Document the permanent delete semantics and bump plugin version to 1.1.9

Verification

  • python3 -m compileall spoolmanapi
  • git diff --check

Copilot AI review requested due to automatic review settings April 28, 2026 07:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Spoolman-compatible API implementation so that deleting a spool via DELETE /spool/{id} performs a true database delete (rather than archiving), while keeping the existing endpoint shape and success response. It also documents the new semantics and bumps the plugin version.

Changes:

  • Change spool deletion behavior to hard-delete the spool record and emit a deleted event.
  • Document that DELETE /spool/{id} is a permanent delete.
  • Bump plugin version from 1.1.8 to 1.1.9.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
spoolmanapi/service.py Switches delete_spool from “archive” to db.delete() + commit while keeping the same API contract.
spoolmanapi/plugin.json Version bump to 1.1.9 to reflect behavior change.
README.md Updates endpoint description and adds a “Delete semantics” section clarifying permanent deletion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants