-
Notifications
You must be signed in to change notification settings - Fork 129
✨ Implement structured generation and Remote Config #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implement structured generation and Remote Config #141
Conversation
Summary of ChangesHello @peterfriese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the 'FriendlyMeals' application by introducing structured AI generation for recipes and integrating Firebase Remote Config for dynamic parameter management. It also adds a usage tracking system and a paywall, laying the groundwork for potential monetization or feature gating. These changes improve the robustness of AI responses and provide greater flexibility in managing app behavior remotely. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces structured generation using JSON schema and integrates Firebase Remote Config to manage model parameters. It also adds usage tracking with a daily limit, showing a paywall when the limit is reached. The changes are well-structured, separating concerns into different services. However, the core feature of using Remote Config values in the view model is incomplete, and there are a few areas for improvement regarding robustness and code style. My review includes critical feedback on the Remote Config integration and suggestions to prevent potential crashes and improve code maintainability.
...-meals/apple/FriendlyMeals/FriendlyMeals/Features/SuggestRecipe/SuggestRecipeViewModel.swift
Show resolved
Hide resolved
...eals/apple/FriendlyMeals/FriendlyMeals/Features/SuggestRecipe/SuggestRecipeDetailsView.swift
Show resolved
Hide resolved
...-meals/apple/FriendlyMeals/FriendlyMeals/Features/SuggestRecipe/SuggestRecipeViewModel.swift
Outdated
Show resolved
Hide resolved
...friendly-meals/apple/FriendlyMeals/FriendlyMeals/Features/Services/RemoteConfigService.swift
Show resolved
Hide resolved
...riendly-meals/apple/FriendlyMeals/FriendlyMeals/Features/Services/UsageTrackingService.swift
Show resolved
Hide resolved
...-meals/apple/FriendlyMeals/FriendlyMeals/Features/SuggestRecipe/SuggestRecipeViewModel.swift
Show resolved
Hide resolved
880e0db
into
peterfriese/friendlymeals-functioncalling-optimize
No description provided.