Skip to content

Merge putDtype and putType; remove duplicated code #8610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Noremos
Copy link
Contributor

@Noremos Noremos commented Jun 18, 2025

This is also a preparation for the JSON Type implementation

@Noremos Noremos changed the title Merge putDtype and putType, remove duplicate code Merge putDtype and putType; remove duplicated code Jun 18, 2025
Copy link
Member

@asfernandes asfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you not choose better names for methods you created to not duplicate code, I prefer to have the code duplicated.
I understand nothing what the refactored methods do by their names.

@Noremos
Copy link
Contributor Author

Noremos commented Jun 19, 2025

If you not choose better names for methods you created to not duplicate code, I prefer to have the code duplicated. I understand nothing what the refactored methods do by their names.

I tried to follow the style of the original method names. putType and putDtype are not the most transparent names either. So it would be nice if you could suggest alternative names for my methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants