Per pagespace I/O statistics and new trace API interfaces to allow extendable statistics #8808
Conversation
dyemanov
commented
Nov 22, 2025
dyemanov
commented
- Deprecate non-extendable PerformanceInfo struct in favor of the new PerformanceCounters/PerformanceStats interfaces
- Adjust the trace implementation to the new API
- Add internal support for per-pagespace I/O statistics. It's not used now, but will be used by PR Support for tablespaces #8314. This part is moved here to simplify review of the tablespaces.
…e PerformanceInfo struct in favor of the new PerformanceCounters/PerformanceStats interfaces. Adjust the trace implementation to the new API.
|
Documentation is missing. |
| uint64 getElapsedTime(); // in milliseconds | ||
| uint64 getFetchedRecords(); | ||
|
|
||
| PerformanceCounters getGlobalCounters(); |
There was a problem hiding this comment.
If you claim expandability, this must be one function with enum parameter: cGlobal, cPage, cRelation.
There was a problem hiding this comment.
We can easily add more functions to extend the interface. But I may agree a single function would be simpler.
|
|
||
| uint getId(uint index); | ||
| const string getName(uint index); | ||
| const int64* getCounterVector(uint index); |
There was a problem hiding this comment.
TTL of returned value is...?
There was a problem hiding this comment.
TTL of returned value is...?
It corresponds to the object TTL.
There was a problem hiding this comment.
Well... Returning of a plain array is simple and effective, but doesn't quite fit the ideology of OO API. How about returning of another object with methods getRead, getWrites, getFetches, etc? In this case getVectorCapacity is not needed (I guess).
| uint getVectorCapacity(); | ||
|
|
||
| uint getId(uint index); | ||
| const string getName(uint index); |
There was a problem hiding this comment.
ID and name of... what?
Object (table, tablespace, whatever) counters belong to. Would you suggest getObjectId() / getObjectName()?
There was a problem hiding this comment.
No, I just wonder what these methods shall return for Global and Page counters.
There was a problem hiding this comment.
Nothing (zero) for global, valid id/name otherwise.
There was a problem hiding this comment.
Perhaps, it could be useful to return hardcoded "Global" and "Pages" in these cases...
True, to be added. |
2 participants
