Skip to content

reset p1 and p2 to null after 2nd click #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peanutzy1 wants to merge 1 commit into from
Closed

reset p1 and p2 to null after 2nd click #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/playerCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,9 @@ export const commands = commandList({
if(args.action) outputFail(`There is no recorded history for the selected region matching the provided filters.`);
else outputFail(`There is no recorded history for the selected region.`);
}
if(limitTiles == amount)
output(`Displaying first ${limitTiles} entries. To show other entries, increase the limit or select a smaller area.`);
if(limitTiles == amount){
output(`Displaying first ${limitTiles} entries. To show other entries, increase the limit or select a smaller area.`)
}
}
const p1 = cachedPointMap[sender.uuid];
if(!p1){
Expand All @@ -215,6 +216,8 @@ export const commands = commandList({
const height = Math.abs(p1[1] - p2[1]);
if(width > 50 || height > 50) fail("Selection too large: width/height cannot be more than 50.");
handleArea(p1, p2);
p1 = null;
Copy link
Member

@BalaM314 BalaM314 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't do anything. p1 is just a temporary variable. You need to modify cachedPointMap to clear the data

Copy link
Contributor Author

@Peanutzy1 Peanutzy1 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e
11:30pm rn im under a blanket while typing on a phone
cuz my mom moved into mah room now (for reasons)

p2 = null;
if(!args.persist) handleTaps("off");
}
},
Expand Down
Loading