Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build-errors): update format statements to no longer cause build errors #7

Closed
wants to merge 1 commit into from

Conversation

ProjectBarks
Copy link

This commit addresses inconsistencies in log formatting and data types in the esp_ghota.c file. Specifically:

  • Corrected log formatting in the ghota_check function to use %d instead of %lld for content_length.
  • Ensured consistent data type usage in log formatting for partition addresses in the validate_image_header and ghota_storage_update functions, using %x instead of (int) cast.
  • Updated log formatting in ghota_storage_update to use %d for partition size instead of %lu.
  • Adjusted log formatting in ghota_start_update_timer to use %d for the update interval instead of %lu.

These changes ensure code consistency and compatibility across different platforms, resolving the build failures encountered due to log formatting and data type inconsistencies.

@Fishwaldo
Copy link
Owner

There was a change to the uint32_t underlying size between 4.4 and 5.0 of esp-idf - So while this fixed for newer esp-idf versions, it broke 4.4 and earlier releases. Ive just pushed fixes that are backwards compatible instead. Thanks for the effort tho.

@Fishwaldo Fishwaldo closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants