-
Notifications
You must be signed in to change notification settings - Fork 13
Create toggle for logo #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @jcorbalanm, thanks for your PR! Interesting idea, do you dislike the logo? |
Fivefold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, small but clean PR!
| </label> | ||
| <div class="form-input-hint"> | ||
| Shows or hides the extension logo on the results title. | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to order the options from most important to least important. Personally, I think hiding the logo is something few people will need, so I would put it last in the advanced settings. Feel free to share your thoughts if this is a bad idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know where to put it. Putting it under "Default open link type" seems good idea. I don't know how many people change the Theme of injection box, but obviously we can put it at the bottom, I have no problem with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fivefold I don't necessarily dislike it but i prefer a more minimalist look on my search results. I made this PR pretty much for myself because I found it easy. |



Small change to enable and disable logo visibility (enabled by default). Tested.