Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Editable installation with external TritonJIT
```shell
pip install -U scikit-build-core ninja cmake pybind11

CMAKE_ARGS="-DFLAGGEMS_BUILD_C_EXTENSIONS=ON -DDFLAGGEMS_USE_EXTERNAL_TRITON_JIT=ON -DTritonJIT_ROOT=<install path of triton-jit>" \
CMAKE_ARGS="-DFLAGGEMS_BUILD_C_EXTENSIONS=ON -DFLAGGEMS_USE_EXTERNAL_TRITON_JIT=ON -DTritonJIT_ROOT=<install path of triton-jit>" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thank you for correcting the typo for the FLAGGEMS_USE_EXTERNAL_TRITON_JIT flag. While reviewing this line, I noticed a related inconsistency within this document that could confuse users. You are correctly using the plural form FLAGGEMS_BUILD_C_EXTENSIONS here, which aligns with its definition in CMakeLists.txt. However, the description on line 50 refers to it using the singular form, FLAGGEMS_BUILD_C_EXTENSION. To maintain consistency and prevent potential user errors, I recommend updating the variable on line 50 to its plural form as well.

pip install --no-build-isolation -v -e .
```

Expand Down