-
Notifications
You must be signed in to change notification settings - Fork 145
fix:remove extra 'D' from FLAGGEMS_USE_EXTERNAL_TRITON_JIT in CMAKE_ARGS #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wlxjhyf
wants to merge
1
commit into
master
Choose a base branch
from
xjh-temp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for correcting the typo for the
FLAGGEMS_USE_EXTERNAL_TRITON_JIT
flag. While reviewing this line, I noticed a related inconsistency within this document that could confuse users. You are correctly using the plural formFLAGGEMS_BUILD_C_EXTENSIONS
here, which aligns with its definition inCMakeLists.txt
. However, the description on line 50 refers to it using the singular form,FLAGGEMS_BUILD_C_EXTENSION
. To maintain consistency and prevent potential user errors, I recommend updating the variable on line 50 to its plural form as well.