Skip to content

fix:remove extra 'D' from FLAGGEMS_USE_EXTERNAL_TRITON_JIT in CMAKE_ARGS #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix:remove extra 'D' from FLAGGEMS_USE_EXTERNAL_TRITON_JIT in CMAKE_ARGS #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Editable installation with external TritonJIT
```shell
pip install -U scikit-build-core ninja cmake pybind11

CMAKE_ARGS="-DFLAGGEMS_BUILD_C_EXTENSIONS=ON -DDFLAGGEMS_USE_EXTERNAL_TRITON_JIT=ON -DTritonJIT_ROOT=<install path of triton-jit>" \
CMAKE_ARGS="-DFLAGGEMS_BUILD_C_EXTENSIONS=ON -DFLAGGEMS_USE_EXTERNAL_TRITON_JIT=ON -DTritonJIT_ROOT=<install path of triton-jit>" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thank you for correcting the typo for the FLAGGEMS_USE_EXTERNAL_TRITON_JIT flag. While reviewing this line, I noticed a related inconsistency within this document that could confuse users. You are correctly using the plural form FLAGGEMS_BUILD_C_EXTENSIONS here, which aligns with its definition in CMakeLists.txt. However, the description on line 50 refers to it using the singular form, FLAGGEMS_BUILD_C_EXTENSION. To maintain consistency and prevent potential user errors, I recommend updating the variable on line 50 to its plural form as well.

pip install --no-build-isolation -v -e .
```

Expand Down