-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log sigmoid #408
base: master
Are you sure you want to change the base?
Add log sigmoid #408
Conversation
…/FlagGems into add_log_sigmoid
Could you refer to pytorch/pytorch#1835 for better numerical stability? |
ok,i will try it |
'-inf' was handled correctly. log_sigmoid(-inf) = -inf, but now it returns nan. |
Please also add '-inf', 'inf', -300, to UT. |
Please check your results for input -inf, inf, -300, all in float16. They are expected to be -inf, 0, -300. Please verify. Thanks. |
ok,fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Operator
Type of Change
New Feature
Description
Implement log_sigmoid operator
Issue
#389
Progress
Performance