deps!: remove node18 support and update pino #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
changed the title
emyller
reviewed
Nov 10, 2025
emyller
left a comment
emyller
left a comment
There was a problem hiding this comment.
Changes looks good, but I'm mostly intrigued about the engine code changes.
There was a problem hiding this comment.
These changes look related with the engine, and IIRC are required by recent tests.
Should we include them in this pull request though?
Contributor
Author
There was a problem hiding this comment.
Sorry, good catch. Looks like those have been included by some kind of pre-commit hook... I'll look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates pino dependency to resolve CVE, and removes support for node 18.
Resolves #219