-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overage-billing): use relative delta and months, instead of days #5060
Merged
matthewelwell
merged 4 commits into
main
from
fix/ensure-billing-created-for-all-customers
Feb 12, 2025
Merged
fix(overage-billing): use relative delta and months, instead of days #5060
matthewelwell
merged 4 commits into
main
from
fix/ensure-billing-created-for-all-customers
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5060 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 1214 1214
Lines 42308 42312 +4
=======================================
+ Hits 41224 41228 +4
Misses 1084 1084 ☔ View full report in Codecov by Sentry. |
Docker builds report
|
khvn26
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since a billing period for anyone on a monthly billing cycle is a month, not 30 days, we should use a month to determine the period in which we're looking for previous usage notifications.
How did you test this code?
Updated an existing unit test.