Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overage-billing): use relative delta and months, instead of days #5060

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jan 30, 2025

Changes

Since a billing period for anyone on a monthly billing cycle is a month, not 30 days, we should use a month to determine the period in which we're looking for previous usage notifications.

How did you test this code?

Updated an existing unit test.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:31am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:31am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:31am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Uffizzi Preview deployment-60455 was deleted.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (3f7c9da) to head (82b6967).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5060   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42308    42312    +4     
=======================================
+ Hits        41224    41228    +4     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Jan 30, 2025
@matthewelwell matthewelwell marked this pull request as ready for review February 11, 2025 11:31
@matthewelwell matthewelwell requested a review from a team as a code owner February 11, 2025 11:31
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team February 11, 2025 11:31
@github-actions github-actions bot added fix and removed fix labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5060 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5060 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5060 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5060 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5060 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5060 Finished ✅ Results

@github-actions github-actions bot added the fix label Feb 11, 2025
@matthewelwell matthewelwell merged commit 03261dd into main Feb 12, 2025
59 checks passed
@matthewelwell matthewelwell deleted the fix/ensure-billing-created-for-all-customers branch February 12, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants