fix: service to use default credentials mode when cookie auth disabled #5079
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
front-end
|
@blackjid is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Uffizzi Ephemeral Environment
|
|
Thanks @blackjid , one of the team will take a look at this and get back to you soon. |
tiagoapolo
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
There was a problem when the cookie authentication is disabled and we expect some cookies to be send on the requests. This was an issue when using Cloudflare Access, where the authentication sets the
CF_Authenticationcookie that is needed. The refactor addcredentials: omitto the fetch method, which cause all requests to fail before reaching the flagsmith api.The change of behaviour was introduced here
To fix it the service that call api endpoints from the frontend now uses the default value for
credentialswhen the cookie authentication is disabled. This is the same behaviour it used to have before the cookie authentication refactor.How did you test this code?
I test it manually using the content override feature of the chrome developer tools.