-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deletes provider and displays warning in selected env #5085
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, however, I feel that the environment-level warning is too buried at the moment. A user would need to open the dropdown to see them.
Can we highlight the dropdown somehow to direct users attention to the dropdown in case when one of the not currently selected environments is unhealthy?
@tiagoapolo, sorry, there's a pretty minor, but rather annoying styling issue with the tooltip here when appearing over an environment banner. ![]() Otherwise, this all looks good to me now. |
Indeed, that happens mainly because we need a more consistent z-index value management for handling component hierarchy. Ideally we want to render tooltips and alike in portals. This PR will fix that issue. |
bbedf58
to
b2462fd
Compare
@@ -20,20 +20,28 @@ import TagUsage from 'components/TagUsage' | |||
|
|||
type AddEditTagsType = { | |||
value?: number[] | |||
hideTagsByType?: string[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth us having a defined UNION type here? If so lets put it in the Tag type in responses.ts
small comment other than that all good 👍 |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Ref: #3615
Environment without unhealthy features example
![Screenshot 2025-02-10 at 10 37 55](https://private-user-images.githubusercontent.com/2777865/411579016-8395d3f9-02e0-49b2-83fc-178458413329.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyOTEzMTcsIm5iZiI6MTczOTI5MTAxNywicGF0aCI6Ii8yNzc3ODY1LzQxMTU3OTAxNi04Mzk1ZDNmOS0wMmUwLTQ5YjItODNmYy0xNzg0NTg0MTMzMjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTYyMzM3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzgyYzFlMGNjYmE2NjAxNTEwNDJiN2RlYmJkOGNmZmMyZjM3MGIyYjYxNzUwNTYzYzJhYzI2ZDgzNTdjZDZhZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.DeJrX94W2YxQhJC-99NZVFhaT1Y0mXRH62qyvMfWTbw)
How did you test this code?
Selected env warning
Delete a provider