Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-export): handle unsuccessful feature export download exception #5086

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 10, 2025

Changes

Handle exception thrown when trying to download a feature export that is not yet complete.

Fixes sentry error https://flagsmith.sentry.io/issues/5800328361

How did you test this code?

Added specific test cases.

@matthewelwell matthewelwell requested a review from a team as a code owner February 10, 2025 15:30
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team February 10, 2025 15:30
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 3:52pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 3:52pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 3:52pm

@github-actions github-actions bot added the api Issue related to the REST API label Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5086 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5086 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5086 Finished ✅ Results

@github-actions github-actions bot added the fix label Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Uffizzi Ephemeral Environment deployment-60783

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5086

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added fix and removed fix labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (3f7c9da) to head (ae57aaf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5086   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42308    42318   +10     
=======================================
+ Hits        41224    41234   +10     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant