Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrates webhooks to RTK #5087

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tiagoapolo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • This pull request implements useWebhooks custom hook in order to replace withWebhooks
  • Migrates webhooks state to RTK

How did you test this code?

@tiagoapolo tiagoapolo self-assigned this Feb 11, 2025
@tiagoapolo tiagoapolo requested a review from a team as a code owner February 11, 2025 01:22
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 11, 2025 01:22
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5087 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5087 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5087 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5087 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5087 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5087 Finished ✅ Results

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 1:23am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 1:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 11, 2025 1:23am

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Uffizzi Ephemeral Environment deployment-60801

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5087

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@@ -0,0 +1,24 @@
import {
useCreateWebhookMutation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this simplifies syntax I'm not sure this file is necessary, we don't have this sort of pattern elsewhere - can just use the useCreate etc directly

@kyle-ssg
Copy link
Member

I think this PR should probably remove the withWebhooks.js functionality to be complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants