feat: Add xoxp/xoxb token support for conversations_unreads #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fallback implementation for conversations_unreads tool that works with xoxp and xoxb tokens by iterating through channels and using conversations.info to check unread_count. The ClientCounts API (used in the original implementation) only works with browser session tokens (xoxc/xoxd) and returns empty results for OAuth tokens (xoxp/xoxb). This change detects when ClientCounts returns empty results and automatically falls back to the per-channel approach. Implementation details: - Added GetConversationInfoContext to SlackAPI interface - New helper method getUnreadsUsingConversationsInfo implements xoxp approach - Automatically detects empty ClientCounts response and switches to fallback - Logs info message when using fallback method - Maintains same output format and filtering options as original - Note: mentions_only filter not supported with xoxp (logged as warning) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Author
|
Closing to recreate against main repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds fallback implementation for
conversations_unreadstool that works with xoxp and xoxb tokens.Problem
The current implementation of
conversations_unreadsuses theClientCountsAPI, which only works with browser session tokens (xoxc/xoxd). When used with OAuth tokens (xoxp/xoxb), it returns empty results.Solution
This PR adds an automatic fallback that:
ClientCountsfirst (fast path for xoxc/xoxd)ClientCountsreturns empty resultsconversations.infoto checkunread_counton each channelImplementation Details
getUnreadsUsingConversationsInfoimplements the per-channel approachClientCountsreturns zero channels and switches to fallbackGetConversationInfoContexttoSlackAPIinterfaceLimitations
mentions_onlyfilter is not supported with xoxp tokens (no access to mention counts viaconversations.info)mentions_onlyis requested with xoxp tokenslastReadandlatesttimestamps are not available viaconversations.info(returned as empty strings)Testing
Stacked PR
This PR is stacked on top of korotovsky#171 and targets the
feat-unreads-rebasebranch.🤖 Generated with Claude Code