feat: add state-of-charge sensor to flex-model #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Garcia Reolid <[email protected]>
victorgarcia98
added
enhancement
Contributor
|
So the scheduler saves SoC planning to this sensor, but we are not yet using it for anything else, like a starting SoC? That should be clearer in the documentation (on schema and CLI) |
Flix6x
requested changes
Mar 27, 2025
added 13 commits
April 1, 2025 09:31
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Flix6x
requested changes
Apr 1, 2025
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Almost there. Nice that you included the CLI already, too.
Co-authored-by: Felix Claessen <[email protected]> Signed-off-by: Victor <[email protected]>
Co-authored-by: Felix Claessen <[email protected]> Signed-off-by: Victor <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Co-authored-by: Felix Claessen <[email protected]> Signed-off-by: Victor <[email protected]>
Co-authored-by: Felix Claessen <[email protected]> Signed-off-by: Victor <[email protected]>
added 2 commits
April 2, 2025 00:37
…eature/plannin/save-soc
Signed-off-by: Victor Garcia Reolid <[email protected]>
Flix6x
requested changes
Apr 1, 2025
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Nice. This is going to be super helpful. I just found one more potential bug in how the CLI command sets the job kwargs, and please add a changelog entry for 0.26.0.
added 3 commits
April 2, 2025 10:51
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
added 2 commits
April 2, 2025 11:17
Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: Victor Garcia Reolid <[email protected]>
Flix6x
added a commit
that referenced
this pull request
Jun 2, 2025
Signed-off-by: F.N. Claessen <[email protected]>
Flix6x
added a commit
that referenced
this pull request
Jun 2, 2025
Signed-off-by: F.N. Claessen <[email protected]>
Flix6x
added a commit
that referenced
this pull request
Jun 2, 2025
* docs: api changelog entry for #1392 Signed-off-by: F.N. Claessen <[email protected]> * docs: update main changelog entry for #1392 Signed-off-by: F.N. Claessen <[email protected]> * docs: update month of 0.26 release Signed-off-by: F.N. Claessen <[email protected]> --------- Signed-off-by: F.N. Claessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the field
state-of-charge, a sensor to save the state of charge associated with an schedule. In the future, we could use this sensor to get the starting SOC.Related Items
This PR is based on the work of #1018 but it starts from scratch given the recent changes on multi asset scheduling.