OD-746 [Feature] Added show password function #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytlwu
requested changes
Jun 6, 2022
css/form.css
Outdated
| @@ -7,6 +7,13 @@ | |||
| opacity: 0.65; | |||
| } | |||
|
|
|||
| .fa-eye, .fa-eye-slash { | |||
There was a problem hiding this comment.
Please limit this to the widget instance context.
Suggested change
| .fa-eye, .fa-eye-slash { | |
| .fl-form .fa-eye, .fl-form .fa-eye-slash { |
| type="password" | ||
| class="form-control focus-outline" | ||
| :type="isShowPassword ? 'text' : 'password'" | ||
| class="form-control focus-outline input-password" |
There was a problem hiding this comment.
What is the purpose of the input-password class name?
Suggested change
| class="form-control focus-outline input-password" | |
| class="form-control focus-outline" |
| <label for="confirm-yes"> | ||
| <span class="check"><i class="fa fa-circle"></i></span> <strong>Yes</strong> - Add a password confirmation field | ||
| <span class="check"><i class="fa fa-circle"></i></span> <strong :class="{'text-muted': canShowPassword}">Yes</strong> - Add a password confirmation field |
There was a problem hiding this comment.
Suggested change
| <span class="check"><i class="fa fa-circle"></i></span> <strong :class="{'text-muted': canShowPassword}">Yes</strong> - Add a password confirmation field | |
| <span class="check"><i class="fa fa-circle"></i></span> <strong :class="{ 'text-muted': canShowPassword }">Yes</strong> - Add a password confirmation field |
| <input type="checkbox" :name="name" v-model="canShowPassword" id="password-show-checkbox" :disabled="confirm"> | ||
| <label for="password-show-checkbox"> | ||
| <span class="check"><i class="fa fa-check"></i></span> | ||
| <span class="hide-field" :class="{'text-muted': confirm}">Yes, please.</span> |
There was a problem hiding this comment.
Suggested change
| <span class="hide-field" :class="{'text-muted': confirm}">Yes, please.</span> | |
| <span class="hide-field" :class="{ 'text-muted': confirm }">Yes, please.</span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@romanyosyfiv @inna-bieshulia
OD-746 https://weboo.atlassian.net/browse/OD-746
Description
Screenshots/screencasts
www.awesomescreenshot.com/video/7898374?key=f9b553451702e462f73af9c397621638
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko