Fix/DEV-504: Fixes bugs and applies improvements in Multi-step form flow #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armine-fliplet
changed the title
zeryabkhan91
reviewed
May 8, 2025
js/libs/form.js
Outdated
| formData['Created at'] = new Date().toISOString(); | ||
| formData['Last updated'] = ''; | ||
| } | ||
| } else if (type === 'flDateRange' || type === 'flTimeRange') { |
There was a problem hiding this comment.
@armine-fliplet please fix this spacing issue
zeryabkhan91
reviewed
May 8, 2025
js/libs/form.js
Outdated
| formData[`${field.name} [${val}]`] = ''; | ||
| }); | ||
| } | ||
| } else if (!(field._type === 'flButtons' || field._type === 'flCustomButton')) { |
There was a problem hiding this comment.
@armine-fliplet Fix spacing here as well
zeryabkhan91
reviewed
May 8, 2025
js/libs/builder.js
Outdated
Comment on lines
1101
to
1112
| if (form.sliderContainerId !== currentForm.sliderContainerId) continue; | ||
|
|
||
| if (currentForm.id === form.id) isCurrentForm = true; | ||
|
|
||
| if (currentFormDsId !== formDsId) continue; | ||
|
|
||
| let hasFlButton = false; | ||
|
|
||
| for (let i = form.fields.length - 1; i >= 0; i--) { | ||
| const field = form.fields[i]; | ||
|
|
||
| if (field._type === 'flButtons' && field.showSubmit !== false && currentFormDsId === formDsId) { hasFlButton = true; break; } |
There was a problem hiding this comment.
@armine-fliplet Please add if statements in block instead of single line.
zeryabkhan91
reviewed
May 8, 2025
inna-bieshulia
merged commit 7eda5ef
into
projects/DEV-206-multi-step-form
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product areas affected
Fliplet Form Builder
What does this PR do?
Fixes bugs and applies improvements in Multi-step form flow
JIRA ticket
DEV-491
DEV-500
DEV-501
DEV-502
DEV-504
DEV-506