-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow topic metadata to be viewed and edited #5080
base: mqtt-topic-schema-storge
Are you sure you want to change the base?
Conversation
Just spotted the big commented out preHandler that needs updating - putting back to draft 😆 |
Have fixed the perms check. Working on test failures now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mqtt-topic-schema-storge #5080 +/- ##
============================================================
+ Coverage 78.49% 78.52% +0.03%
============================================================
Files 337 337
Lines 15772 15779 +7
Branches 3634 3639 +5
============================================================
+ Hits 12380 12391 +11
+ Misses 3392 3388 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass of all the backend code looks good, bar the one comment about the type/inferredSchema bit.
UI looks good when testing, haven't looked too closely at the vue code.
Will review again when not draft
Co-authored-by: Ben Hardill <[email protected]>
Have improved test coverage when using the |
Closes #5046
This PR targets the
mqtt-topic-schema-storge
branch that is delivered by #5053Description
Adds the ability to view and edit topic metadata in the UI.
I expect some updates around tests to follow today.