Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow topic metadata to be viewed and edited #5080

Open
wants to merge 6 commits into
base: mqtt-topic-schema-storge
Choose a base branch
from

Conversation

knolleary
Copy link
Member

Closes #5046

This PR targets the mqtt-topic-schema-storge branch that is delivered by #5053

Description

Adds the ability to view and edit topic metadata in the UI.

image

I expect some updates around tests to follow today.

@knolleary knolleary requested a review from hardillb February 6, 2025 10:17
@knolleary knolleary marked this pull request as draft February 6, 2025 10:17
@knolleary
Copy link
Member Author

Just spotted the big commented out preHandler that needs updating - putting back to draft 😆

@knolleary
Copy link
Member Author

Have fixed the perms check. Working on test failures now.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (bafc741) to head (c01312f).

Files with missing lines Patch % Lines
forge/ee/routes/teamBroker/3rdPartyBroker.js 92.30% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           mqtt-topic-schema-storge    #5080      +/-   ##
============================================================
+ Coverage                     78.49%   78.52%   +0.03%     
============================================================
  Files                           337      337              
  Lines                         15772    15779       +7     
  Branches                       3634     3639       +5     
============================================================
+ Hits                          12380    12391      +11     
+ Misses                         3392     3388       -4     
Flag Coverage Δ
backend 78.52% <94.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of all the backend code looks good, bar the one comment about the type/inferredSchema bit.

UI looks good when testing, haven't looked too closely at the vue code.

Will review again when not draft

@knolleary knolleary marked this pull request as ready for review February 6, 2025 14:13
@knolleary
Copy link
Member Author

Have improved test coverage when using the team-broker id. Happy for final review.

@knolleary knolleary requested a review from hardillb February 6, 2025 14:13
@knolleary knolleary linked an issue Feb 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define topic descriptions
3 participants