-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3rd Party broker endpoint #5081
Conversation
GET /api/v1/teams/:teamId/brokers/:brokerId returns a broker object (with no credentials) and a exrtra status field that shows if the client is connected to the broker Also fix the schema for the broker apis and fixes the db.views.BrokerCredentials functons
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mqtt-topic-schema-storge #5081 +/- ##
============================================================
- Coverage 78.49% 78.36% -0.13%
============================================================
Files 337 337
Lines 15772 15829 +57
Branches 3634 3654 +20
============================================================
+ Hits 12380 12405 +25
- Misses 3392 3424 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing up linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending changes:
- Fixed up an erorr message typo.
- Renamed
3rdPartyBroker
toMQTTBroker
in the schema as it feels cleaner.
Co-authored-by: Nick O'Leary <[email protected]>
Test failure is in device groups so merging anyway. Can review tests in lower branch before merging to main |
Description
returns a broker object (with no credentials) and a extra
status
field that shows if the client is connected to the brokerThis is to be used to add a status pill to 3rd party brokers
Also fix the schema for the broker apis and fixes the db.views.BrokerCredentials functons
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label