Update schema generate for 3rd party brokers #5083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mqtt-topic-metadata #5083 +/- ##
=======================================================
- Coverage 78.52% 78.38% -0.15%
=======================================================
Files 337 337
Lines 15779 15822 +43
Branches 3639 3653 +14
=======================================================
+ Hits 12391 12402 +11
- Misses 3388 3420 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hardillb
approved these changes
Feb 6, 2025
Comment on lines
+93
to
+96
| if (request.broker.credentials) { | ||
| const creds = JSON.parse(request.broker.credentials) | ||
| if (creds.username && creds.password) { | ||
| schema.servers[request.broker.name].security = [{ |
There was a problem hiding this comment.
broker.credentials are never returned to the UI
There was talk of sending credentials.username back, but not implemented at the moment.
| @@ -1,6 +1,4 @@ | |||
| module.exports = async function (app) { | |||
| app.addHook('preHandler', app.verifySession) | |||
There was a problem hiding this comment.
Is this removed because it's already set somewhere earlier?
| @@ -1,8 +1,6 @@ | |||
| const schemaApi = require('./schema') | |||
|
|
|||
| module.exports = async function (app) { | |||
| app.addHook('preHandler', app.verifySession) | |||
There was a problem hiding this comment.
same as in 3rdPartyBroker.js?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5082
Description
Adds support for asyncapi schema generation for 3rd party brokers.
metadatamodel definition to provide custom get/set functions - consumers don't need to worry about JSON parse/stringify.