Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog: add a changelog entry for hidden env vars #2947

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Changelog: add a changelog entry for hidden env vars #2947

merged 3 commits into from
Feb 3, 2025

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jan 28, 2025

Description

Adds a changelog entry for the hidden vars feature

Related Issue(s)

closes #2946

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@cstns cstns requested a review from knolleary January 28, 2025 13:06
@cstns cstns self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 6.7%, saving 16.31 KB.

Filename Before After Improvement Visual comparison
src/changelog/2025/01/images/hidden-env-var-devices.png 133.07 KB 123.66 KB -7.1% View diff
src/changelog/2025/01/images/hidden-env-var-instances.png 110.10 KB 103.20 KB -6.3% View diff

1588 images did not require optimisation.

knolleary
knolleary approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've expanded 'env var' to 'environment variables' to be clearer. Otherwise, good to go

@knolleary knolleary merged commit 7357b14 into main Feb 3, 2025
5 checks passed
@knolleary knolleary deleted the add-hidden-env-var-changelog branch February 3, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@cstns cstns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changelog for Hidden Env Vars
2 participants
@cstns @knolleary