Skip to content

Fix: Indexing fails with Neos 8.2 with ApiException in cleanupOldIndicies #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Indexing fails with Neos 8.2 with ApiException in cleanupOldIndicies #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ed415
Handle PSR Response before json decode
marcrobertscamao Feb 7, 2023
eb3fc9d
Update UpdateAliasJob.php
marcrobertscamao Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Classes/UpdateAliasJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Neos\Flow\Annotations as Flow;
use Neos\Flow\Log\Utility\LogEnvironment;
use Neos\Flow\Utility\Algorithms;
use Psr\Http\Message\ResponseInterface;
use Psr\Log\LoggerInterface;

class UpdateAliasJob implements JobInterface
Expand Down Expand Up @@ -137,7 +138,7 @@ protected function cleanupOldIndices(): void
}
}
} catch (ApiException $exception) {
$response = json_decode($exception->getResponse(), true, 512, JSON_THROW_ON_ERROR);
$response = json_decode($exception->getResponse() instanceof ResponseInterface ? $exception->getResponse()->getBody()->__toString() : (string) $exception->getResponse(), true, 512, JSON_THROW_ON_ERROR);
if ($response->error instanceof \stdClass) {
$this->logger->error(sprintf('Old indices for alias %s could not be removed. ElasticSearch responded with status %s, saying "%s: %s"', $this->indexPostfix, $response->status, $response->error->type, $response->error->reason), LogEnvironment::fromMethodName(__METHOD__));
} else {
Expand Down