fix: typed Window interface, dedupe Math.floor, unlock-chart tests, semantic hover token - #453
Open
Mozez155 wants to merge 1 commit into
Open
fix: typed Window interface, dedupe Math.floor, unlock-chart tests, semantic hover token#453Mozez155 wants to merge 1 commit into
Mozez155 wants to merge 1 commit into
Conversation
…e Math.floor calls, add toX/toY tests, replace hardcoded hover colors with semantic token closes FlowwStar#443 closes FlowwStar#442 closes FlowwStar#434 closes FlowwStar#441
|
@Mozez155 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare global { interface Window { freighter?; xBullSDK?; lobstrSDK? } }inwallet-provider.tsxwith minimal typed shapes for each SDK, removing all 7(window as any)casts.const nowSec = Math.floor(Date.now() / 1000)indashboard-stats.tsxand reused it across all four predicates inhasActiveStreams.toX/toYfromunlock-chart.tsxand added unit tests in__tests__/components/unlock-chart.test.tscovering start/end boundaries, midpoints, quarter-points, and zero/negative edge cases.hover:bg-gray-100 dark:hover:bg-gray-800inThemeToggle.tsxwith the semantichover:bg-mutedtoken used across the rest of the app.Test plan
npm test—unlock-chart.test.tstests should passcloses #443
closes #442
closes #434
closes #441