Skip to content

Rename status to phase for list_pods #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Rename status to phase for list_pods #130

merged 1 commit into from
Apr 29, 2025

Conversation

Flux159
Copy link
Owner

@Flux159 Flux159 commented Apr 24, 2025

See #129

Summary:

Test Plan:

@Flux159
Copy link
Owner Author

Flux159 commented Apr 29, 2025

Merging, will create minor release with this fix.

@Flux159 Flux159 merged commit fb2f7c6 into main Apr 29, 2025
1 of 2 checks passed
@Hwting
Copy link
Contributor

Hwting commented Apr 29, 2025

image @Flux159 Does the status of containerStatus still require PR? However, it will increase the token of the large model

@Flux159
Copy link
Owner Author

Flux159 commented Apr 29, 2025

@Hwting How valuable is it for the llm to have the entire containerStatuses array vs having the exact result from kubectl? Considering that there may be some changes in the results of all the list_{x} methods in a next major release with something like #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants