Added OATH, cleaned up curl for GET/POST, and more #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added post support internally and OATH 2 usage so you can now make authorized requests and not be limited to information passed back from the Api. Also added a new GET function getGroups(). Cleaned up usage to match example and instead of returning $response->results only $response is returned so you can iterate over $response->results properly, otherwise you'd be missing all of the other information included in the json object which is useful.
Added more usage information b/c of OATH inclusion. Also cleaned up reference to $response->meta_total_count to $response->meta->total_count
Added parameter behind the scenes so we don't have to for authorize routine.
Added some more background information about including parameters behind the scenes
Some cleanup and straight forward usage without try catch blocks.
Added information about using try/catch blocks.
Added the missing return statement in refresh() call, otherwise you won't get back the details you need for access.
Fixed bug where overwrote member variable parameters, shouldn't do that per request in case we want to re-use object multiple times based off constructor parameters. Added javadoc documentation to document the code and give small code examples. Added put/delete support on top of get/post. However post/put/delete require authorized access. Added a post and delete stub method.
Reflect current state with new post/delete functionality and stub methods
Updated readme to reflect new functionality for get/post/put/delete
Fixed bug when building GET request, if parameters are empty don't append '?' to the url just leave it as is, issue when building requests but also using getNext() since the data was already in the url.
Return null in getNext() for easier processing instead of throwing if there's no next responses to get.
Added new function hasNext for checking meta data in case it has the next request to make to get remaining data. Store response internally so we don't have to pass anything to hasNext() or getNext() and it updates internal as it's called. Also make it easier for getting the next result set if available for requests.
Reflect new state of hasNext() and getNext()
Improved check for hasNext() in meta link for additional results and how it's used in getNext(). Now checking if the meta data is set and if it is if the link isn't empty before accepting that we have additional results to process.
Added composer
Posting events works now. Also changed the HTML response code detection. postEvent will return 201 if successful: https://www.meetup.com/meetup_api/docs/2/event/
Fixed postEvent and updateEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Great library it was just missing a few things for my requirements. I've added OATH support and cleaned up the curl interface, it now also supports get/post/delete/put calls so it can be easily expanded for adding more stub GET/POST/DELETE methods too. Adjusted getNext() so it's easy to iterate over more responses and stored the response internally.
Updated the Readme as well to include new information and quick start guide using OATH. I also want to add more functionality down the road but this is where I'm at now. Welcome more testing and improvements.
Would like to add member variables and beef up the object as well but don't have time right now.