Skip to content

Conversation

@VincentMolinie
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Dec 18, 2025

24 new issues

Tool Category Rule Count
qlty Duplication Found 18 lines of identical code in 2 locations (mass = 123) 6
qlty Structure Function with many parameters (count = 5): constructor 4
qlty Duplication Found 16 lines of similar code in 2 locations (mass = 88) 12
qlty Structure Function with high complexity (count = 23): routes 1
qlty Structure Function with many returns (count = 8): getField 1

@VincentMolinie VincentMolinie force-pushed the feat/agent-testing branch 2 times, most recently from 9ddd452 to fa37d49 Compare January 5, 2026 13:48
Vincent Molinié and others added 7 commits January 6, 2026 14:32
Add @forestadmin/datasource-customizer directly to prevent yarn from
creating nested node_modules with different versions in CI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Force consistent versions of @forestadmin/datasource-toolkit and
@forestadmin/datasource-customizer across all packages to prevent
type mismatches when _example downloads from npm.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add @forestadmin/forestadmin-client to resolutions to prevent
agent-testing from downloading a nested copy from npm.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add comment to yarn.lock to bust the CI cache and force fresh
node_modules installation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add @forestadmin/forestadmin-client to _example to ensure the
resolution forces the correct version instead of pulling 1.37.1
from npm through transitive dependencies.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Cast ForestAdminClientMock to any to avoid type mismatch when
yarn creates nested node_modules with different forestadmin-client
versions due to transitive dependency resolution.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@qltysh
Copy link

qltysh bot commented Jan 7, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

"dependencies": {
"@faker-js/faker": "^7.6.0",
"@forestadmin/agent": "1.70.1",
"@forestadmin/datasource-customizer": "1.67.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

"@forestadmin/agent": "1.70.1",
"@forestadmin/datasource-customizer": "1.67.2",
"@forestadmin/datasource-dummy": "1.1.60",
"@forestadmin/forestadmin-client": "1.37.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove


The MCP server will be automatically initialized and mounted on your application.

#### Framework Compatibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

"@babel/helpers": "^7.26.10",
"semantic-release": "^25.0.0"
"semantic-release": "^25.0.0",
"@forestadmin/datasource-toolkit": "1.50.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dependencies are added ?

@@ -0,0 +1,23 @@
import { ForestServerActionFormLayoutElement } from '@forestadmin/forestadmin-client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove remove-agent-client folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants