feat: Add Defi spring (SNF Style) rewards decoder and sanitizer#2
Open
akiraonstarknet wants to merge 1 commit intoForgeYields:mainfrom
Open
feat: Add Defi spring (SNF Style) rewards decoder and sanitizer#2akiraonstarknet wants to merge 1 commit intoForgeYields:mainfrom
akiraonstarknet wants to merge 1 commit intoForgeYields:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Defi Spring (SNF Style) rewards claiming functionality by implementing a new decoder and sanitizer component. The changes introduce a new component that can handle reward claiming operations following the standard contract structure used by SNF for rewards.
- Adds a new defi_spring_snf_style module with interface and implementation
- Integrates the new component into the existing SimpleDecoderAndSanitizer contract
- Provides a claim function interface for reward claiming with amount and proof parameters
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/vault_allocator/src/lib.cairo | Adds module declaration for defi_spring_snf_style |
| packages/vault_allocator/src/decoders_and_sanitizers/simple_decoder_and_sanitizer.cairo | Integrates the new component with imports, storage, events, and implementation |
| packages/vault_allocator/src/decoders_and_sanitizers/defi_spring_snf_style/interface.cairo | Defines the interface for Defi Spring SNF Style decoder with claim function |
| packages/vault_allocator/src/decoders_and_sanitizers/defi_spring_snf_style/defi_spring_snf_style_decoder_and_sanitizer.cairo | Implements the component with a placeholder claim function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...oders_and_sanitizers/defi_spring_snf_style/defi_spring_snf_style_decoder_and_sanitizer.cairo
Show resolved
Hide resolved
7ea29a1 to
9d3d2b4
Compare
0xSacha
pushed a commit
that referenced
this pull request
Dec 7, 2025
Fix hyperlane decoder and add to simple decoder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.