Skip to content

Adds missing peer dependencies - #180

Closed
arcanis wants to merge 1 commit into
FormidableLabs:masterfrom
arcanis:patch-1
Closed

arcanis wants to merge 1 commit into
FormidableLabs:masterfrom
arcanis:patch-1

Conversation

@arcanis

@arcanis arcanis commented Jan 6, 2020

Copy link
Copy Markdown

Missing peer dependencies cause package managers to incorrectly hoist packages, causing subtle breakages particularly hard to debug.

@arcanis

arcanis commented Nov 19, 2024

Copy link
Copy Markdown
Author

Out of curiosity, why did this get closed?

@carbonrobot

carbonrobot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

@arcanis The package.json for the module already contains peerDeps. The file being updated in this PR is the root monorepo package.json and is unrelated to the module itself, so it doesn't need peerDeps.

Since this was opened several years ago, it was likely resolved by a different developer over time, I'm just cleaning up the stale issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants