Skip to content

Update actions/cache and actions/setup-node to v4 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 14, 2025

Conversation

djm158
Copy link
Contributor

@djm158 djm158 commented Dec 17, 2024

Description

  • Previously used actions/cache to configure yarn cache - replaced with actions/setup-node
  • Update any other usage of actions/cache to v4
  • Updates the demo app action to run on macos-14 targeting iPhone 15 Pro device running ios 18.1. I had previously attempted macos-13 and iPhone 14 Pro but the build step took >20 minutes to complete, whereas macos-14 the build took ~7 minutes (macos-14 runs on m1 hardware)
  • Updated futureware-tech/simulator-action to v4 and set some additional config values to get CI working
  • actions/upload-artifact also updated to v4

Type of Change

  • Adding or updating CI (Actions)

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (I have run yarn prettier:apply)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 6d073bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-owl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 2:32pm

@djm158 djm158 changed the title Update to use actions/cache@v4 and setup-node for caching node… Update actions/cache and actions/setup-node to v4 Dec 17, 2024
Copy link
Contributor

@JDMathew JDMathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for updating ios version. I'll fix safe areas in a separate PR

@djm158 djm158 merged commit e3e383d into main Jan 14, 2025
7 checks passed
@djm158 djm158 deleted the chore/update-actions-cache branch January 14, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants