Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cute-foxes-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"victory-native": patch
---

fix native container prop forwarding
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ const RectWithStyle = ({
export const VictoryBrushContainer = (
initialProps: VictoryBrushContainerNativeProps,
) => {
const props = useVictoryBrushContainer({
const { props, children } = useVictoryBrushContainer({
...initialProps,
brushComponent: initialProps.brushComponent ?? <RectWithStyle />,
handleComponent: initialProps.handleComponent ?? <RectWithStyle />,
});
return <VictoryContainer {...props} />;
return <VictoryContainer {...props}>{children}</VictoryContainer>;
};

VictoryBrushContainer.role = "container";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ export interface VictoryCursorContainerNativeProps
export const VictoryCursorContainer = (
initialProps: VictoryCursorContainerNativeProps,
) => {
const props = useVictoryCursorContainer({
const { props, children } = useVictoryCursorContainer({
...initialProps,
cursorLabelComponent: initialProps.cursorLabelComponent ?? <VictoryLabel />,
cursorComponent: initialProps.cursorComponent ?? <LineSegment />,
});
return <VictoryContainer {...props} />;
return <VictoryContainer {...props}>{children}</VictoryContainer>;
};

VictoryCursorContainer.role = "container";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ const DefaultSelectionComponent = ({
export const VictorySelectionContainer = (
initialProps: VictorySelectionContainerNativeProps,
) => {
const props = useVictorySelectionContainer({
const { props, children } = useVictorySelectionContainer({
...initialProps,
// @ts-expect-error TODO: standalone is not a valid prop for VictoryContainer, figure out why this is here
standalone: initialProps.standalone ?? true,
selectionComponent: initialProps.selectionComponent ?? (
<DefaultSelectionComponent />
),
});
return <VictoryContainer {...props} />;
return <VictoryContainer {...props}>{children}</VictoryContainer>;
};

VictorySelectionContainer.role = "container";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ const DEFAULT_VORONOI_PADDING = 5;
export const VictoryVoronoiContainer = (
initialProps: VictoryVoronoiContainerNativeProps,
) => {
const props = useVictoryVoronoiContainer({
const { props, children } = useVictoryVoronoiContainer({
...initialProps,
activateData: initialProps.activateData ?? true,
activateLabels: initialProps.activateLabels ?? true,
labelComponent: initialProps.labelComponent ?? <VictoryTooltip />,
voronoiPadding: initialProps.voronoiPadding ?? DEFAULT_VORONOI_PADDING,
});
return <VictoryContainer {...props} />;
return <VictoryContainer {...props}>{children}</VictoryContainer>;
};

VictoryVoronoiContainer.role = "container";
Expand Down