Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile examples #245

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Compile examples #245

wants to merge 6 commits into from

Conversation

ext
Copy link
Contributor

@ext ext commented Feb 3, 2025

  • tsc kompilerar alla typescript/javascript exempel
  • eslint körs på alla typescript/eslint exempel
  • sass kompilerar alla scss exempel
  • stylelint körs på alla css och scss exempel

Man kan använda nocompile och nolint taggarna om man inte vill köra ett visst verktyg:

```ts nocompile
/* detta exemplet kommer inte kompileras men lintas fortfarande */
```

Vad är då fördelen med detta? Jo att vi lättare kan refaktorisera och ändå se att våra exempel lirar. Exempelvis om vi ändrar en funktion så vill man ju se att de ställen där vi hänvisar till det i koden så lirar det fortfarande. Vi ser också att rätt saker faktiskt är exporterade från paketen.

Copy link

github-actions bot commented Feb 3, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://Forsakringskassan.github.io/designsystem/pr-preview/pr-245/

Built to branch gh-pages at 2025-02-07 07:28 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Contributor

@dvitamin dvitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snyggt!

@ext ext force-pushed the docs/compile-examples branch from 593aa5a to 95af627 Compare February 4, 2025 15:36
@ext ext force-pushed the docs/compile-examples branch from 95af627 to 11dbe63 Compare February 6, 2025 23:36
@ext ext force-pushed the docs/compile-examples branch from 11dbe63 to 17b5530 Compare February 6, 2025 23:49
@@ -419,7 +419,7 @@ Som konsument finns det möjlighet att själv tillhandahålla specifika tillämp

Möjlighet finns att importera separat vid behov.

```scss
```scss nocompile
@use "@fkui/theme-default/src/deprecated-css-variables" as *;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvitamin Detta smäller, filen hittas inte. Kan du slänga ett öga på det?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants