-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile examples #245
Open
ext
wants to merge
6
commits into
main
Choose a base branch
from
docs/compile-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compile examples #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext
requested review from
dvitamin,
MCFK,
NicklasWei,
kristofernilsson,
Marie-Jakobsson,
kristinalindstrom and
mitra-Re
as code owners
February 3, 2025 17:37
ext
force-pushed
the
docs/compile-examples
branch
from
February 3, 2025 17:45
eb859f0
to
593aa5a
Compare
|
dvitamin
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snyggt!
MCFK
approved these changes
Feb 4, 2025
ext
force-pushed
the
docs/compile-examples
branch
from
February 4, 2025 15:36
593aa5a
to
95af627
Compare
ext
force-pushed
the
docs/compile-examples
branch
from
February 6, 2025 23:36
95af627
to
11dbe63
Compare
ext
force-pushed
the
docs/compile-examples
branch
from
February 6, 2025 23:49
11dbe63
to
17b5530
Compare
ext
commented
Feb 6, 2025
@@ -419,7 +419,7 @@ Som konsument finns det möjlighet att själv tillhandahålla specifika tillämp | |||
|
|||
Möjlighet finns att importera separat vid behov. | |||
|
|||
```scss | |||
```scss nocompile | |||
@use "@fkui/theme-default/src/deprecated-css-variables" as *; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvitamin Detta smäller, filen hittas inte. Kan du slänga ett öga på det?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsc
kompilerar alla typescript/javascript exempeleslint
körs på alla typescript/eslint exempelsass
kompilerar alla scss exempelstylelint
körs på alla css och scss exempelMan kan använda
nocompile
ochnolint
taggarna om man inte vill köra ett visst verktyg:Vad är då fördelen med detta? Jo att vi lättare kan refaktorisera och ändå se att våra exempel lirar. Exempelvis om vi ändrar en funktion så vill man ju se att de ställen där vi hänvisar till det i koden så lirar det fortfarande. Vi ser också att rätt saker faktiskt är exporterade från paketen.