feat: update Modal with semantic tokens (refs SFKUI-7034) #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johancarnegard
requested review from
ext,
dvitamin,
NicklasWei,
MCFK,
OlofFredriksson,
TMFKse,
mitra-Re and
jameseklund
as code owners
|
ext
approved these changes
Feb 11, 2025
| --f-text-color-close-button: var(--f-text-color-default-inverted); | ||
| &--information #{$MODAL_SELECTOR}__shelf { | ||
| background-color: $modal-shelf-info-color-background; | ||
| .close-button { |
There was a problem hiding this comment.
Jag är ok med detta men vill ändå påpeka att det strider mot BEM.
Om vi tycker det är viktigt så bör vi lägga på ytterligare en klass på sträng-knappen.
dvitamin
reviewed
Feb 11, 2025
| @@ -42,7 +43,7 @@ $modal-width: calc(100vw - 40px) !default; // 100% - 20px each side; | |||
| &__shelf { | |||
| justify-content: flex-end; | |||
| display: flex; | |||
| background-color: var(--f-background-modal-shelf); | |||
dvitamin
reviewed
Feb 11, 2025
| @@ -151,17 +153,21 @@ $modal-width: calc(100vw - 40px) !default; // 100% - 20px each side; | |||
| } | |||
| } | |||
|
|
|||
| &--information { | |||
| --f-background-modal-shelf: var(--f-border-color-info); | |||
There was a problem hiding this comment.
Enda beroendet kvar till denna variablen, --f-border-color-info är i message-box. Föreslår att merga message-box-prn först #208 och sedan deprekera variablen i samband med denna prn.
dvitamin
reviewed
Feb 11, 2025
| } | ||
|
|
||
| &--warning { | ||
| --f-background-modal-shelf: var(--f-border-color-warning); |
There was a problem hiding this comment.
Enda beroendet kvar till denna variablen, --f-border-color-warning är i message-box. Föreslår att merga message-box-prn först #208 och sedan deprekera variablen i samband med denna prn.
MCFK
approved these changes
Feb 12, 2025
dvitamin
force-pushed
the
feature/tokens_modal
branch
from
8d8c14c to
810f3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modalen har nya komponentspecifika variabler för färger kopplat till de semantiska variablerna. Modalen har fått en transparent outline för att möjliggöra tillräcklig kontrast mot bakgrunden vid forced-color mode (aka högkontrastläge).