Added rollback to when there are db errors #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Fluxticks
commented
Feb 13, 2022
Fluxticks
commented
- Resolves DB Errors are not rolled back #209
Member
|
Does postgres support transactions? |
Collaborator
Author
|
That is a great question that I had not considered. The changes were in relation to an error that occured with this as the suggested fix. Turned out the error was actually unrelated, but I thought in theory not bad to implement |
Member
|
Yep, seems like a good idea. Postgres has transaction support: https://www.postgresql.org/docs/9.5/tutorial-transactions.html. I'll approve this PR but it's probably worth examining transactions as an idea to supercede it. |
Laura7089
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.