Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked & described some telemetry data #5

Merged
merged 7 commits into from
Feb 22, 2025
Merged

Conversation

PhoneDroid
Copy link
Contributor

@PhoneDroid PhoneDroid commented Feb 21, 2025

Linked & gave examples for some of the collected data.
Fixed headings ( There should only ever be one <h1> / # ! )

Didn't have time to go through the remaining stuff, for now

@chennes
Copy link
Member

chennes commented Feb 21, 2025

I'm keeping these to raw markdown, don't add those HTML tags. The Qt Markdown parser doesn't like them.

@PhoneDroid PhoneDroid marked this pull request as draft February 21, 2025 16:15
@PhoneDroid PhoneDroid marked this pull request as ready for review February 21, 2025 16:18
@chennes
Copy link
Member

chennes commented Feb 21, 2025

You've also got some trailing whitespace that the hook can't edit for you (you don't allow edits from maintainers). If you install pre-commit on this repo running git commit --amend will do that for you.

@PhoneDroid
Copy link
Contributor Author

Ah sorry, I'm used to my editorconfig taking care of that ..

@PhoneDroid
Copy link
Contributor Author

Forgot, actually those trailing white spaces have meaning.
This is Markdown, double trailing white spaces are line breaks!

@PhoneDroid
Copy link
Contributor Author

Now it looks completely wrong ..

@chennes
Copy link
Member

chennes commented Feb 21, 2025

If you're still working on it, convert it to draft -- otherwise it looks ready to go to me.

@PhoneDroid PhoneDroid marked this pull request as draft February 21, 2025 22:55
@PhoneDroid PhoneDroid marked this pull request as ready for review February 21, 2025 23:10
@PhoneDroid
Copy link
Contributor Author

I added the markdown flag for the trailing-whitespace hook.

@chennes chennes merged commit 8a01319 into FreeCAD:main Feb 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants