Skip to content

Allowing no file in the PathProcessor #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrade-leonardo
Copy link
Contributor

In cases where the database record has the file field set to null, deleting the record will result in a type error in the $data field, as null is not an acceptable value at that moment.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (f7052a5) to head (9a49833).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #614      +/-   ##
============================================
+ Coverage     95.86%   95.90%   +0.04%     
- Complexity      110      111       +1     
============================================
  Files            11       11              
  Lines           290      293       +3     
============================================
+ Hits            278      281       +3     
  Misses           12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrade-leonardo
Copy link
Contributor Author

About the trailing comma errors, I'm open to fixing them if needed.

@gersonfs
Copy link
Contributor

gersonfs commented Apr 2, 2025

Same issue here. Occurs when removing a record where the field that would store the file name is null.

@ADmad
Copy link
Member

ADmad commented Apr 2, 2025

Calling getPathProcessor() with a null value makes no sense. Instead the changes should be made to the calling method to simply not try getting the path processor if the db value is null.

@andrade-leonardo
Copy link
Contributor Author

I made the change to no longer call the getPathProcessor() method as you suggested. I believe this is indeed more appropriate

@gersonfs
Copy link
Contributor

@ADmad anything else we can contribute to get this PR approved?

@ADmad ADmad merged commit d545ef3 into FriendsOfCake:master Apr 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants