Skip to content

fix docs & return types of Doctrine_Record::safe() and Doctrine_Record::trySafe() #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix docs & return types of Doctrine_Record::safe() and Doctrine_Record::trySafe() #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b048c6c
Update Record.php
vidschofelix Aug 14, 2025
ee1d45a
Update Record.php
vidschofelix Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions lib/Doctrine/Record.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1725,11 +1725,11 @@ public function resetPendingUnlinks()
*
* this method also saves the related components
*
* @param Doctrine_Connection $conn optional connection parameter
* @throws Exception if record is not valid and validation is active
* @param Doctrine_Connection|null $conn optional connection parameter
* @return void
* @throws Exception if record is not valid and validation is active
*/
public function save(?Doctrine_Connection $conn = null)
public function save(?Doctrine_Connection $conn = null): void
{
if ($conn === null) {
$conn = $this->_table->getConnection();
Expand All @@ -1743,10 +1743,12 @@ public function save(?Doctrine_Connection $conn = null)
* throw an exception when validation fails but returns TRUE on
* success or FALSE on failure.
*
* @param Doctrine_Connection $conn optional connection parameter
* @return TRUE if the record was saved sucessfully without errors, FALSE otherwise.
* @param Doctrine_Connection|null $conn optional connection parameter
* @return bool TRUE if the record was saved successfully without errors, FALSE otherwise.
* @throws Exception
*/
public function trySave(?Doctrine_Connection $conn = null) {
public function trySave(?Doctrine_Connection $conn = null): bool
{
try {
$this->save($conn);
return true;
Expand Down