fix: WebSocket reconnect loop causing memory leak#4
Open
neavra wants to merge 1 commit intoFrondEnt:mainfrom
Open
fix: WebSocket reconnect loop causing memory leak#4neavra wants to merge 1 commit intoFrondEnt:mainfrom
neavra wants to merge 1 commit intoFrondEnt:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a WebSocket connection drops, both
errorandcloseevents fire, each callingscheduleReconnect(). Sinceterminate()also triggersclose, you get 2 reconnect timers instead of 1. After repeated disconnects this could compound exponentially (2→4→8→16...), potentially spawning many parallel connections.I believe this may be causing memory/CPU spikes in long-running processes, though I haven't confirmed with profiling. Either way, this is a good defensive fix to prevent duplicate reconnect timers.