Group Settings panes into clearer subsections#413
Merged
Conversation
- General: add Status and Help section titles so the top and bottom groups have headers - Writing: rename the top section to Length and split the Profile card into Profile (Name), Languages, and Rules so each editor sits in its own card - Apps: rename the section to Disabled Apps so it does not duplicate the tab title - Shortcuts: split Acceptance Mode and keybinds into Mode and Keys sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the Settings layout so every grouped card has a meaningful header and related controls live together.
Statusheader, and the trailing Open Welcome Guide row gets aHelpheader instead of floating below Appearance.Length(the pane itself is already titled Writing), and the Profile mega-card is split into three cards:Profile(caption + Name), Languages, and Rules. Each editor renders its own internal label and Clear control.Disabled Appsso it doesn't duplicate the tab title.Mode(acceptance mode picker) andKeys(Accept Word, Accept Entire Suggestion).Copy-only / layout-only change. No behavior, persistence, or binding changes.
Validation
Local SwiftLint pass (
swiftlint lint --quieton the four modified files): exit 0. Did not run xcodebuild this round; changes are pure SwiftUI section rearrangement.Linked issues
Risk / rollout notes
Low risk; affects only the redesigned Settings panes under
Cotabby/UI/Settings/Panes/.Greptile Summary
This is a pure SwiftUI layout reorganisation across the four Settings panes and the two shared editor components (
LanguageTagsEditor,CustomRulesEditor). No bindings, persistence, or business logic are touched.Sectionheaders are given explicit labels ("Status", "Help", "Mode", "Keys", "Disabled Apps"); the Shortcuts pane is split from one section into two.Sections (Profile, Languages, Rules); a newshowsTitleHeader: Bool = trueparameter on both editor components lets the Section header carry the label while preserving the Clear button, with the defaulttruekeeping existing callers (SettingsView,WelcomeProfileStepView) unchanged.Confidence Score: 5/5
Safe to merge — all changes are SwiftUI Section header renames and card splits with no logic, binding, or persistence modifications.
Every file touched is a pure layout reorganisation: string literals for Section headers are renamed or added, one pane is split into two sections, and two shared editor components gain an opt-in
showsTitleHeaderparameter that defaults totrue, leaving all existing call sites (SettingsView,WelcomeProfileStepView) behaviorally identical. There are no data model, persistence, or control-flow changes anywhere in the diff.No files require special attention.
Important Files Changed
Reviews (2): Last reviewed commit: "Address review: broaden Writing caption,..." | Re-trigger Greptile