Port expanded About support copy to redesigned AboutPaneView#421
Merged
Conversation
PR #411 expanded the support copy in the legacy SettingsView but did not touch AboutPaneView, which is the pane the redesigned Settings window actually shows (gated by isRedesignEnabled, on by default). Copy the same two-paragraph mission + ask into the live pane so users see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#411 expanded the support copy in About from one paragraph to two, but it edited
Cotabby/UI/SettingsView.swift, which is the legacy settings root. The pane the redesigned Settings window actually shows isCotabby/UI/Settings/Panes/AboutPaneView.swift(see its own file header: "Consolidates what used to live across three legacy sections..."). The redesign is gated byisRedesignEnabledinSettingsCoordinatorand is on for users, so #411's copy never reached the UI.This ports the same two-paragraph mission + ask into
AboutPaneView.supportRow.Validation
Visual check deferred to a screenshot on the running app; the diff is a 1-to-1 copy port from the legacy view's expanded label into a
VStack(alignment: .leading, spacing: 8)inside the existingLabeledContentlabel, matching how the legacy view did it.Linked issues
Refs #411.
Risk / rollout notes
@ViewBuilder. No control flow, no state, no new dependencies.SettingsView.swiftis left untouched. It is still wired behindisRedesignEnabledinSettingsCoordinator, so deleting it is a separate decision.Greptile Summary
This PR ports the expanded two-paragraph support copy (introduced in #411) from the legacy
SettingsView.swiftinto the redesignedAboutPaneView.swift, which is the pane that actually renders for users whenisRedesignEnabledis true.supportRowwith aVStack(alignment: .leading, spacing: 8)containing twoTextviews, matching the structure added toSettingsView.swiftin Expand About support copy to two excerpts #411 character-for-character.@ViewBuilderproperty.Confidence Score: 5/5
Safe to merge — copy-only change with no logic, state, or dependency impact.
The change is a character-for-character port of two Text strings and their VStack container from the legacy SettingsView.swift into AboutPaneView.swift. There is nothing to break: no control flow, no state mutations, no new imports, and the modifier chain is identical to the source. The legacy view is left untouched, so neither code path regresses.
No files require special attention.
Important Files Changed
supportRowreplaced with a two-paragraphVStack; copy and modifiers are a 1-to-1 match of the legacy view. No logic changes.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[SettingsCoordinator] -->|isRedesignEnabled = true| B[AboutPaneView] A -->|isRedesignEnabled = false| C[SettingsView - legacy] B --> D[supportRow] D --> E["VStack(alignment: .leading, spacing: 8)"] E --> F["Text: mission statement (paragraph 1)"] E --> G["Text: support ask (paragraph 2)"] D --> H["Link → ko-fi.com/cotabby"] C --> I["supportSection (unchanged)"] I --> J["Same two-paragraph copy (source of truth for #411)"]Reviews (1): Last reviewed commit: "Port expanded About support copy to rede..." | Re-trigger Greptile