Remove redundant 'Type to search emoji' label from emoji picker#460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
:is typed to trigger the emoji picker, two affordances were shown simultaneously: the:prefix in the header and the "Type to search emoji" hint in the content area. The header already makes the search context obvious, so the text label was redundant noise.The empty-query state now shows a silent
Color.clearplaceholder of the same height, keeping the panel geometry unchanged. "No emoji found" still appears when the user has typed a query that matches nothing.Validation
Linked issues
Risk / rollout notes
Panel sizing is unchanged —
EmojiPickerPanelLayout.contentSizestill reserves one row for the empty state.Greptile Summary
This PR removes the "Type to search emoji" hint text from the emoji picker's content area when the query is empty, replacing it with a transparent
Color.clearspacer of identical height. The header's:prefix already provides sufficient context, making the hint redundant.Color.clearplaceholder that preservesEmojiPickerMetrics.rowHeight, keeping panel geometry unchanged.Confidence Score: 5/5
Safe to merge — the change touches only one view branch, preserves panel geometry, and does not alter any logic or state.
The diff is a minimal, self-contained UI tweak: one branch of a @ViewBuilder property replaces a Text view with a same-sized Color.clear spacer. The footer still guides users via 'Keep typing to search,' and the 'No emoji found' path is unchanged. No layout, data, or behavioral regressions are plausible here.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[content computed property] --> B{model.matches.isEmpty?} B -- No --> C[ScrollView with LazyVStack of EmojiPickerRow items] B -- Yes --> D{model.query.isEmpty?} D -- Yes --> E["Color.clear\n(height: rowHeight)\n← new: silent placeholder"] D -- No --> F["Text: 'No emoji found'\n(height: rowHeight)"] style E fill:#d4edda,stroke:#28a745Reviews (1): Last reviewed commit: "Remove redundant 'Type to search emoji' ..." | Re-trigger Greptile