Skip to content

Address Greptile review on onboarding feature showcase #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FuJacob merged 1 commit into from
May 31, 2026
Merged

Address Greptile review on onboarding feature showcase #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Cotabby/UI/Onboarding/OnboardingFeatureShowcase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ struct OnboardingFeatureShowcase: View {
GhostTextDemoCard()
EmojiPickerDemoCard()
}
// Purely decorative looping demo: hide it from VoiceOver so the
// mid-animation text fragments are never read out to AT users.
.accessibilityHidden(true)
}
}

Expand Down Expand Up @@ -136,6 +139,7 @@ private struct GhostTextDemoCard: View {
withAnimation(.easeInOut(duration: 0.30)) {
showGhost = false
accepted = false
typedCount = 0
}
try? await Task.sleep(nanoseconds: 600 * nsPerMillisecond)
}
Expand Down Expand Up @@ -277,7 +281,7 @@ private struct DemoEmojiPopup: View {
Divider()

VStack(spacing: 0) {
ForEach(Array(candidates.enumerated()), id: \.offset) { index, candidate in
ForEach(Array(candidates.enumerated()), id: \.element.alias) { index, candidate in
DemoEmojiRow(glyph: candidate.glyph, alias: candidate.alias, isSelected: index == 0)
}
}
Expand Down