Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore prefix syntax not in prefix position #1229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thatismatt
Copy link

Fixes #1212 by ignoring the prefix syntax flag once point is inside the symbol.

I've added a few tests that hopefully illustrate the issue/expected behaviour.

@bbatsov
Copy link
Contributor

bbatsov commented Mar 25, 2025

@Fuco1 I'd appreciate it if you can take a look at this one, as it's affecting Clojure users. (that's how the PR came to my attention)

@fboulay
Copy link

fboulay commented Mar 26, 2025

I tried this commit, and it's not fixing the issue described in #1212

@deejayem
Copy link

I tried this commit, and it's not fixing the issue described in #1212

@fboulay it fixes the issue for me.

E.g. f|oo? -> (|foo?) (where | is the position of the cursor).

@fboulay
Copy link

fboulay commented Mar 26, 2025

@deejayem you're right. My configuration was bad, and I did not pull the right commit. This fixes the issue as well for me.

@deejayem
Copy link

deejayem commented Apr 7, 2025

@Fuco1 I've been using this since it was created, and (after the second commit) it's been working without any issues.

It would be great if this could be merged, as I know a lot of people are affected by the bug (since names ending with ? are common in Clojure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent commit breaks wrapping symbols with question marks in them
4 participants