Skip to content

[HOTFIX] SYNC opPosition null 조건 없앰 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ja7811 merged 1 commit into from
Mar 13, 2025
Merged

[HOTFIX] SYNC opPosition null 조건 없앰 #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/gdg/backend/domain/operation/dto/OperationRequestDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class OperationRequestDto {

Integer deleteLength;

@NotNull(message = "position은 null일 수 없습니다.")
// @NotNull(message = "position은 null일 수 없습니다.")
Long position;

Long baseVersion;
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/gdg/backend/domain/operation/service/OperationQueueProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ public void processOperation(OperationRequestDto operation) {
template.convertAndSend("/sub/edit/" + docId, docContent);
return;
}

// 추후 수정
if(opPosition == null) throw new IllegalStateException("opPosition은 null일 수 없습니다.");

// operation 충돌 시 변환 처리
// - operation의 baseVersion과 서버가 추적하는 version을 비교
Expand Down